Skip to content

Fix/windows int32 issue #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix/windows int32 issue #3151

wants to merge 8 commits into from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jun 18, 2025

There's a windows-specific issue where np.dtype('i') is an instance of np.dtypes.IntDType instead of np.dtypes.Int32DType, which breaks dtype inference. This PR adds logic to the dtype inference for Int32 to handle this case, and adds a test that fails without that fix.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 18, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jun 18, 2025
@d-v-b d-v-b requested a review from dstansby June 19, 2025 09:12
@d-v-b d-v-b mentioned this pull request Jun 19, 2025
Open
@dstansby dstansby added this to the 3.1.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby Awaiting requested review from dstansby

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@d-v-b @dstansby